Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Oct 7, 2025

Closes WOOMOB-70

Description

The "Create Coupon" view did not dismiss the keyboard when the user scrolled if a field was focused. This resulted in a broken scroll behaviour on navigating back and forth from sheets.

This PR resolves the above issue by adding the .scrollDismissesKeyboard(.immediately) to the view's main ScrollView. I've also added the behaviour to the "Usage Restrictions" view.

Steps to reproduce

  1. Open the "Create coupon" sheet for any discount type.
  2. Tap into "Amount".
  3. Note that the keyboard is presented. You don't have to type anything.
  4. Scroll the view.
  5. Note that the keyboard is dismissed, and you can scroll the entire view.
  6. Open "Usage Restrictions".
  7. Tap into any input field.
  8. Note that the keyboard is presented. You don't have to type anything.
  9. Scroll the view.
  10. Note that the keyboard is dismissed, and you can scroll the entire view.

Testing information

Tested and confirmed with the simulator.

Screenshots

Simulator Screen Recording - iPhone 17 Pro - 2025-10-07 at 13 58 00


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas added this to the 23.5 milestone Oct 7, 2025
@adborbas adborbas added the Bug label Oct 7, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 7, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16218-0192577
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit0192577
Installation URL34cpcl7b4dolg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Oct 8, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this works as described :shipit:

@adborbas adborbas merged commit f49c71f into trunk Oct 8, 2025
13 checks passed
@adborbas adborbas deleted the fix/coupon_scrolling branch October 8, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants